Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSI spec dependency to v1.11.0 #3171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepakkinni
Copy link
Contributor

@deepakkinni deepakkinni commented Jan 24, 2025

What this PR does / why we need it:
This PR upgrades the CSI spec to 1.11

As a part of spec upgrade, we needed to support forward compatibility. This needed us to embed UnimplementedControllerServer, UnimplementedNodeServer and UnimplementedIdentityServer in our driver and plugin

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #CNAS-8646

Testing done:
Basic PVC Create/Delete

root@42109f97d934765ce3a2100382eccd0a [ ~ ]# cat pvc.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: pvc-2
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: wcpglobal-storage-profile

root@42109f97d934765ce3a2100382eccd0a [ ~ ]# kubectl apply -f pvc.yaml -n dkinni-ns
persistentvolumeclaim/pvc-2 created

root@42109f97d934765ce3a2100382eccd0a [ ~ ]# kubectl get pvc -n dkinni-ns
NAME    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                VOLUMEATTRIBUTESCLASS   AGE
pvc-1   Bound    pvc-d0500161-a053-485e-9a1f-884a0131b682   1Gi        RWO            wcpglobal-storage-profile   <unset>                 23h
pvc-2   Bound    pvc-75bbb3ca-a477-432c-a07c-36d171cff035   1Gi        RWO            wcpglobal-storage-profile   <unset>                 2m42s

root@42109f97d934765ce3a2100382eccd0a [ ~ ]# kubectl -n dkinni-ns delete pvc pvc-2
persistentvolumeclaim "pvc-2" deleted
root@42109f97d934765ce3a2100382eccd0a [ ~ ]# kubectl get pvc -n dkinni-ns
NAME    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                VOLUMEATTRIBUTESCLASS   AGE
pvc-1   Bound    pvc-d0500161-a053-485e-9a1f-884a0131b682   1Gi        RWO            wcpglobal-storage-profile   <unset>                 23h

Special notes for your reviewer:

Release note:

Update to CSI spec 1.11

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2025
@deepakkinni deepakkinni force-pushed the topic/deepakkinni/up_csi_v1 branch from 9a94dc2 to 99fe9f5 Compare February 5, 2025 21:52
@deepakkinni deepakkinni changed the title [WIP] Update CSI spec dependency to v1.11.0 Update CSI spec dependency to v1.11.0 Feb 5, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@deepakkinni deepakkinni force-pushed the topic/deepakkinni/up_csi_v1 branch from 99fe9f5 to 7304aa7 Compare February 5, 2025 23:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
Signed-off-by: Deepak Kinni <[email protected]>
@deepakkinni deepakkinni force-pushed the topic/deepakkinni/up_csi_v1 branch from 7304aa7 to 4de2906 Compare February 5, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants