Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodeselector to nodeSelector in Helm chart #128

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix nodeselector to nodeSelector in Helm chart #128

merged 1 commit into from
Sep 29, 2023

Commits on Sep 29, 2023

  1. Fix nodeselector to nodeSelector in Helm chart 

    Currently, the default `nodeselector` in the `values.yaml` of the Helm chart is incorrect since it doesn't actually do anything.

```bash
$ helm template --set="nodeselector.hi=bye" gmsa charts/gmsa | yq e 'select(.kind == "Deployment") | .spec.template.spec.nodeSelector'
kubernetes.io/os: linux

$ helm template --set="nodeSelector.hi=bye" gmsa charts/gmsa | yq e 'select(.kind == "Deployment") | .spec.template.spec.nodeSelector'
kubernetes.io/os: linux
hi: bye
```

To fix this, I'm simply modifying `nodeselector` to `nodeSelector` in the default `values.yaml`.
    Arvind Iyengar committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a3020b7 View commit details
    Browse the repository at this point in the history