Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability skip cloud provider #108

Merged

Conversation

tzifudzi
Copy link
Contributor

@tzifudzi tzifudzi commented Jan 28, 2024

What type of PR is this?

enhancement

What this PR does / why we need it:

This PR introduces a feature to selectively skip tests for specific cloud providers in the testing suite. This update is in response to a recurring issue whereby tests exhibit prolonged failures with certain cloud providers, leading to inefficient delays in the testing process. If a test is known to fail, it should either be forcibly failed or skipped outright.

Other changes

  • Fix error bufio.Scanner: token too long by increasing buffer size
  • Fix gitignore which ended up with a weird format and was incorrectly ignoring files
  • Update README with instrunctions for reporting feature

Testing

Sample output in testing

2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Core.Network because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Core.Scheduling because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Core.Storage because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Extend.ActiveDirectory because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Extend.HostProcess because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Extend.Network because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Extend.NetworkPolicy because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Extend.Worker because specification was not specified in category filter
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] 1 / 1 Specifications - Running 1 Test(s) for Ops Readiness specification: Core.Concurrent
2024-01-28T01:28:00-08:00       INFO    [Core.Concurrent] 1 / 1 Tests - Running Operational Readiness Test: Ability to schedule 10 pods concurrently
2024-01-28T01:28:00-08:00       INFO    [Core.Concurrent] 1 / 1 Tests - Skipping Operational Readiness Test for Provider aws: Ability to schedule 10 pods concurrently
2024-01-28T01:28:00-08:00       INFO    Cleaning XML files      {"file": "junit_1101.xml", "path": "report/junit_1101.xml"}
2024-01-28T01:28:00-08:00       INFO    Getting XML content from file   {"path": "report/junit_1101.xml", "category": "Core.Concurrent"}
2024-01-28T01:28:00-08:00       INFO    Saving cleaned tests.   {"number": 2, "index": 1}
2024-01-28T01:28:00-08:00       INFO    [OpReadinessTests] Completed running Ops Readiness tests

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tzifudzi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2024
@tzifudzi tzifudzi force-pushed the feature/add-ability-skip-provider branch from 1e67ece to 28d24f1 Compare January 28, 2024 09:35
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2024
@tzifudzi tzifudzi force-pushed the feature/add-ability-skip-provider branch from 28d24f1 to 6876dd9 Compare January 28, 2024 09:36
@knabben
Copy link
Member

knabben commented Jan 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit ff5f8ee into kubernetes-sigs:main Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants