Temp disable the graceful shutdown e2e test case

[zylxjtu]

this e2e test will need special kubelet config, plan is to move to the e2e node test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zylxjtu
Once this PR has been reviewed and has the lgtm label, please assign claudiubelu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @zylxjtu!

It looks like this is your first PR to kubernetes-sigs/windows-testing 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/windows-testing has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @zylxjtu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jsturtevant]

@marosset this skips the test for our runs but should we be doing something different in the Test itself since it is an Alpha feature?

[marosset]

@marosset this skips the test for our runs but should we be doing something different in the Test itself since it is an Alpha feature?

Hmm, ideally the test case would have a [Fg:xxxx] tag in the title so we could use that to selectively run tests but I believe this feature is past alpha for Linux correct?

In that case maybe we can update the test to query the kubelet config for the node the test is going to run on and skip if the feature isn't enabled?
Ex: https://github.com/kubernetes/kubernetes/blob/39f1c90ac014828803a156b40d49f0c58fb7384a/test/e2e/windows/memory_limits.go#L180C1-L184C47

Since we plan on moving this to e2e_node and that work is progressing I think i'm OK with this impl tho.
WDYT @jsturtevant ?

[jsturtevant]

@zylxjtu do you think we will remove this test once we get to e2e_node? I think it would be ok to have this test here as a general smoke test for the feature. In that case I think we should label it with [Fg:xxxx so we can disable it in the mean time

[zylxjtu]

@zylxjtu do you think we will remove this test once we get to e2e_node? I think it would be ok to have this test here as a general smoke test for the feature. In that case I think we should label it with [Fg:xxxx so we can disable it in the mean time

Not only the feature flag, it will also depend on the kubelet config to specify the shutdown period to be big enough (for example > 30s), by node test, we have the ability to tweak the kubelet config value inside the test, but for e2e test, it will have dependency on how the correpsonding kubelet config is set on the running cluster. So I think it maybe more fit for a node e2e test

But if we can somehow control these kublet parameters for the CPAZ cluster being set up, maybe we can keep it as part of the test grid