Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shubham82 to the reviewers #7507

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Shubham82
Copy link
Contributor

Requirements:
As per: https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer

  • member for at least 3 months - Yes, I have been an active member of the Kubernetes community for more than two years. (Member Request)
  • Primary reviewer for at least 5 PRs to the codebase - Yes, Reviewd 264 PR so far(Open: 9 and closed: 255, merged: 226)
  • Reviewed or merged at least 20 substantial PRs to the codebase - Yes, in addition to the above authored 72 PR so far
  • Knowledgeable about the codebase - Yes
  • Sponsored by a subproject approver
    • With no objections from other approvers
    • Done through PR to update the OWNERS file
  • May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

/assign @gjtempleton

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added area/helm-charts size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@Shubham82
Copy link
Contributor Author

Hi @gjtempleton
Gentle Reminder!

@raywainman
Copy link
Contributor

raywainman commented Nov 25, 2024

/lgtm

Thanks for your help :)

Edit: Thought this was for vpa repo so my LGTM isn't worth much over here but LGTM nonetheless, appreciate all your contributions

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@Shubham82
Copy link
Contributor Author

/lgtm

Thanks for your help :)

Edit: Thought this was for vpa repo so my LGTM isn't worth much over here but LGTM nonetheless, appreciate all your contributions

Thanks @raywainman

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@gjtempleton
Copy link
Member

Thanks for this
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, Shubham82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 444e329 into kubernetes:master Dec 9, 2024
6 checks passed
@Shubham82
Copy link
Contributor Author

Thanks @gjtempleton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants