fix: AWSCloudProvider should ignore unrecognized provider IDs

[raykrueger]

Fixes #8045

The AWSCloudProvider only supports aws://zone/name ProviderIDs. It should ignore ProviderIDs it does not recognize. Prior to this fix, an unrecognized ProviderID, such as eks-hybrid://zone/cluster/my-node which is used by EKS Hybrid Nodes, will break the Autoscaler loop.

This fix returns logs a warning, and returns nil, nil instead of returning the error.

What type of PR is this?

/kind bug

What this PR does / why we need it:

The launch of Amazon EKS Hybrid Nodes introduced a new ProviderID of eks-hybrid://zone/cluster/name. This new ProviderID causes the AWSCloudProvider to break out of it's reconciliation loop because it returns an error when encountering this new ID.

The AWSCloudProvider only supports aws://zone/name ProviderIDs, it should ignore any alternatives (just like it does for a blank iD). This prevents another fix if AWS introduces any alternate IDs in the future.

Which issue(s) this PR fixes:

Fixes #8045

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @raykrueger!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @raykrueger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raykrueger
Once this PR has been reviewed and has the lgtm label, please assign drmorr0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/aws/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[raykrueger]

I had two tabs open, one filled out, one that was not, I just clicked submit on the wrong one. Sigh. Please hold!

[raykrueger]

Ok, all better. Apologies for the spam.

[g-gaston]

/lgtm

[g-gaston]

/ok-to-test

[g-gaston]

/lgtm