-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig-node: update 2024 annual report #8363
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
48bf97c
to
bdd91e7
Compare
Signed-off-by: Peter Hunt <[email protected]>
bdd91e7
to
5ac8d3b
Compare
kindly ping |
as well as announced feature freeze on cgroupv1. | ||
|
||
All of these features don't even begin to cover the amount of CI stabilization, bug fixes, and other work the SIG is doing. We remain a productive (albeit, occasionally overbooked) SIG. To help keep up with all | ||
of the work, we've inducted one new approver Sergey Kanzhelev, reinducted a formerly emertius approver Tim Allclair, welcomed a new SIG chair Peter Hunt, as well as began crafting a role to help KEP authors follow along the KEP process, currently called the KEP wranglers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update.
IIRC, we have a proposal to add more sub domain approvers. Do we have a summary about subproject/sub component approver addition last year?
- I find https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/OWNERS and https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS only ffromani was added in early 2025. The previous adding is in 2022.
|
||
2. Are there any areas and/or subprojects that your group needs help with (e.g. fewer than 2 active OWNERS)? | ||
|
||
SIG-Node, in being so busy, always has a bottleneck of top level approvers. Any path in the kubelet could use more people who have expertise and confidence in reviewing. Please refer to our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To alleviate the bottleneck caused by a limited number of top-level approvers, can we have some strategies?
- Taking KEP as an example, we added approvers for some KEPs like https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1769-memory-manager/OWNERS, https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3960-pod-lifecycle-sleep-action/OWNERS.
- [x] [README.md] reviewed for accuracy and updated if needed | ||
- [x] [CONTRIBUTING.md] reviewed for accuracy and updated if needed | ||
- [x] Other contributing docs (e.g. in devel dir or contributor guide) reviewed for accuracy and updated if needed | ||
- [x] Subprojects list and linked OWNERS files in [sigs.yaml] reviewed for accuracy and updated if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick check on https://github.com/kubernetes/kubernetes/blob/9d9e1afdf78bce0a517cc22557457f942040ca19/OWNERS_ALIASES#L220-L266, IIUC, there are some inactive maintainers, like Random-Liu; and https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS#L13 xueweiz. I does not go through all of them and missing some. And I did not attend the weekly meeting of those and I am not sure if they attend the meetings or have other contributions to the sig or subprojects.
Do we need to do some cleanup on those?
Which issue(s) this PR fixes:
Fixes #8268