Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4876: Mutable CSINode Allocatable Property #4875

Merged
merged 1 commit into from
Jan 29, 2025
Merged

KEP-4876: Mutable CSINode Allocatable Property #4875

merged 1 commit into from
Jan 29, 2025

Conversation

torredil
Copy link
Member

@torredil torredil commented Sep 25, 2024 •
edited
Loading

  • One-line PR description: This PR adds a new KEP for Mutable CSINode Allocatable Property.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2024
@torredil torredil mentioned this pull request Sep 25, 2024
Open
4 tasks
@torredil torredil force-pushed the kep3301 branch 2 times, most recently from 64ae3c9 to b03c3a3 Compare October 3, 2024 17:09
@torredil torredil mentioned this pull request Oct 4, 2024
Open
@torredil torredil force-pushed the kep3301 branch 3 times, most recently from 5b85c07 to cac3da7 Compare October 8, 2024 00:15
@torredil torredil changed the title KEP-3301: Mutable CSINode Allocatable Property KEP-4876: Mutable CSINode Allocatable Property Oct 8, 2024
mauriciopoppe
mauriciopoppe reviewed Oct 8, 2024
View reviewed changes
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Show resolved Hide resolved
@dchen1107 dchen1107 mentioned this pull request Oct 9, 2024
Merged
@alculquicondor
Copy link
Member

/cc

deads2k
deads2k requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@deads2k deads2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRR is sufficient for alpha, but I have some scalability concerns and would like to see some quick back of the envelope math for load and what we can do to mitigate it.

keps/sig-storage/4876-mutable-csinode-allocatable/README.md Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
@deads2k
Copy link
Contributor

deads2k commented Oct 10, 2024

PRR looks good and the scalability section is valuable. We'll have to build it out a little more as we gain experience in alpha.

/approve

alculquicondor
alculquicondor reviewed Oct 10, 2024
View reviewed changes
keps/sig-storage/4876-mutable-csinode-allocatable/README.md

- Modifying the core scheduling logic of Kubernetes.
- Implementing cloud provider-specific solutions within Kubernetes core.
- Re-scheduling pods stuck in a `ContainerCreating` state.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be re-considered in beta, as it sounds like a major pain point for users.

But this is more a question for SIG Node (cc @dchen1107 @SergeyKanzhelev)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference - Important discussion related to this feedback here: #4875 (comment).

keps/sig-storage/4876-mutable-csinode-allocatable/README.md Outdated Show resolved Hide resolved
keps/sig-storage/4876-mutable-csinode-allocatable/kep.yaml Show resolved Hide resolved
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2025
@torredil
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2025
@torredil
Initial KEP check-in
9c7f4a4 
Signed-off-by: torredil <[email protected]>
@msau42
Copy link
Member

msau42 commented Jan 29, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, msau42, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2ca1430 into kubernetes:master Jan 29, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@x13n x13n x13n left review comments

@xing-yang xing-yang xing-yang left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

@aojea aojea aojea left review comments

@deads2k deads2k deads2k requested changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.