-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #16295 from justinsb/refactor_list_elbv2_loadbalan…
…cers Refactor: Move NLB listing function into awsup
- Loading branch information
Showing
4 changed files
with
149 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| /* | ||
| Copyright 2024 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package awsup | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "fmt" | ||
|
|
||
| "github.com/aws/aws-sdk-go/aws" | ||
| "github.com/aws/aws-sdk-go/service/elbv2" | ||
| "k8s.io/klog/v2" | ||
| ) | ||
|
|
||
| type LoadBalancerInfo struct { | ||
| LoadBalancer *elbv2.LoadBalancer | ||
| Tags []*elbv2.Tag | ||
| } | ||
|
|
||
| // ARN returns the ARN of the load balancer. | ||
| func (i *LoadBalancerInfo) ARN() string { | ||
| return aws.StringValue(i.LoadBalancer.LoadBalancerArn) | ||
| } | ||
|
|
||
| // NameTag returns the value of the tag with the key "Name". | ||
| func (i *LoadBalancerInfo) NameTag() string { | ||
| s, _ := i.GetTag("Name") | ||
| return s | ||
| } | ||
|
|
||
| // GetTag returns the value of the tag with the given key. | ||
| func (i *LoadBalancerInfo) GetTag(key string) (string, bool) { | ||
| for _, tag := range i.Tags { | ||
| if aws.StringValue(tag.Key) == key { | ||
| return aws.StringValue(tag.Value), true | ||
| } | ||
| } | ||
| return "", false | ||
| } | ||
|
|
||
| func ListELBV2LoadBalancers(ctx context.Context, cloud AWSCloud) ([]*LoadBalancerInfo, error) { | ||
| // TODO: Any way around this? | ||
| klog.V(2).Infof("Listing all NLBs for ListELBV2LoadBalancers") | ||
|
|
||
| request := &elbv2.DescribeLoadBalancersInput{} | ||
| // ELBV2 DescribeTags has a limit of 20 names, so we set the page size here to 20 also | ||
| request.PageSize = aws.Int64(20) | ||
|
|
||
| byARN := make(map[string]*LoadBalancerInfo) | ||
|
|
||
| var errs []error | ||
| err := cloud.ELBV2().DescribeLoadBalancersPagesWithContext(ctx, request, func(p *elbv2.DescribeLoadBalancersOutput, lastPage bool) bool { | ||
| if len(p.LoadBalancers) == 0 { | ||
| return true | ||
| } | ||
|
|
||
| tagRequest := &elbv2.DescribeTagsInput{} | ||
|
|
||
| for _, elb := range p.LoadBalancers { | ||
| arn := aws.StringValue(elb.LoadBalancerArn) | ||
| byARN[arn] = &LoadBalancerInfo{LoadBalancer: elb} | ||
|
|
||
| // TODO: Any way to filter by cluster here? | ||
|
|
||
| tagRequest.ResourceArns = append(tagRequest.ResourceArns, elb.LoadBalancerArn) | ||
| } | ||
|
|
||
| tagResponse, err := cloud.ELBV2().DescribeTags(tagRequest) | ||
| if err != nil { | ||
| errs = append(errs, fmt.Errorf("listing ELB tags: %w", err)) | ||
| return false | ||
| } | ||
|
|
||
| for _, t := range tagResponse.TagDescriptions { | ||
| arn := aws.StringValue(t.ResourceArn) | ||
|
|
||
| info := byARN[arn] | ||
| if info == nil { | ||
| klog.Fatalf("found tag for load balancer we didn't ask for %q", arn) | ||
| } | ||
|
|
||
| info.Tags = append(info.Tags, t.Tags...) | ||
| } | ||
|
|
||
| return true | ||
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("listing ELB LoadBalancers: %w", err) | ||
| } | ||
| if len(errs) != 0 { | ||
| return nil, fmt.Errorf("listing ELB LoadBalancers: %w", errors.Join(errs...)) | ||
| } | ||
|
|
||
| cloudTags := cloud.Tags() | ||
|
|
||
| var results []*LoadBalancerInfo | ||
| for _, v := range byARN { | ||
| if !MatchesElbV2Tags(cloudTags, v.Tags) { | ||
| continue | ||
| } | ||
| results = append(results, v) | ||
| } | ||
| return results, nil | ||
| } | ||
|
|
||
| func MatchesElbV2Tags(tags map[string]string, actual []*elbv2.Tag) bool { | ||
| for k, v := range tags { | ||
| found := false | ||
| for _, a := range actual { | ||
| if aws.StringValue(a.Key) == k { | ||
| if aws.StringValue(a.Value) == v { | ||
| found = true | ||
| break | ||
| } | ||
| } | ||
| } | ||
| if !found { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } |