Fix nil skipping

kubernetes · Feb 15, 2024 · ea20f85 · ea20f85
1 parent c915a40
commit ea20f85
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/upup/pkg/fi/topological_sort.go b/upup/pkg/fi/topological_sort.go
@@ -66,12 +66,13 @@ func FindTaskDependencies[T SubContext](tasks map[string]Task[T]) map[string][]s
 
 		var dependencyKeys []string
 		for _, dep := range dependencies {
-			if dep == nil {
+			// Skip nils, including interface nils
+			if dep == nil || reflect.ValueOf(dep).IsNil() {
 				continue
 			}
 			dependencyKey, found := taskToId[dep]
 			if !found {
-				klog.Fatalf("dependency not found: %v", dep)
+				klog.Fatalf("dependency for task %T:%q not found: %v", t, k, dep)
 			}
 			dependencyKeys = append(dependencyKeys, dependencyKey)
 		}