-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubetest2-kops: add support for boskos-resource-type flag #15542
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I can verify this once we have kubernetes/test-infra#29907 merged |
669c6b6
to
0e5d198
Compare
/test presubmit-kops-aws-boskos-kubetest2 |
/cc @ameukam |
Adding in dynamic bucket creation, so we don't need to give permissions to a shared bucket to all the boskos accounts /test presubmit-kops-aws-boskos-kubetest2 |
b0d13b2
to
337188d
Compare
/test presubmit-kops-aws-boskos-kubetest2 |
337188d
to
a920251
Compare
/test presubmit-kops-aws-boskos-kubetest2 |
a920251
to
f7ff12b
Compare
/test presubmit-kops-aws-boskos-kubetest2 |
f7ff12b
to
8525919
Compare
/test presubmit-kops-aws-boskos-kubetest2 |
e79b08c
to
f9afe5f
Compare
/test presubmit-kops-aws-boskos-kubetest2 |
@ameukam so I hit some problems with the existing Maybe we try creating some new accounts in a new boskos pool (e.g. resource-type == |
@justinsb we can use those accounts https://github.com/kubernetes/k8s.io/blob/main/infra/aws/terraform/management-account/organization-accounts-boskos.tf#L17-L42 for kOps. They are currently unused. WDYT ? |
@ameukam that sounds good to me - it's great that they under terraform control because if we do need any other permissions we have a good path forwards. Are they loaded into a boskos pool? Any idea how to select them if so - I think I can select a different |
@justinsb They are currently not onboarded. I don't have access to the |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen Let's discuss some more! |
@justinsb: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This will cause AWS tests to acquire an aws-account from boskos (when set to aws-account), and run the tests with those credentials.
When working with boskos, this means we don't need to have a shared bucket with dynamic permissions.
f9afe5f
to
f7612c8
Compare
@justinsb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This will cause AWS tests to acquire an aws-account from boskos (when
set to aws-account), and run the tests with those credentials.