Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubetest2-kops: add support for boskos-resource-type flag #15542

Closed
wants to merge 2 commits into from
Closed

kubetest2-kops: add support for boskos-resource-type flag #15542

wants to merge 2 commits into from

Conversation

justinsb
Copy link
Member

This will cause AWS tests to acquire an aws-account from boskos (when
set to aws-account), and run the tests with those credentials.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

I can verify this once we have kubernetes/test-infra#29907 merged

@justinsb justinsb force-pushed the boskos_kubetest_aws branch from 669c6b6 to 0e5d198 Compare June 22, 2023 15:14
@hakman
Copy link
Member

hakman commented Jun 22, 2023

/test presubmit-kops-aws-boskos-kubetest2

@hakman
Copy link
Member

hakman commented Jun 22, 2023

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam June 22, 2023 17:27
@justinsb
Copy link
Member Author

Adding in dynamic bucket creation, so we don't need to give permissions to a shared bucket to all the boskos accounts

/test presubmit-kops-aws-boskos-kubetest2

@justinsb justinsb force-pushed the boskos_kubetest_aws branch from b0d13b2 to 337188d Compare June 22, 2023 18:39
@justinsb
Copy link
Member Author

/test presubmit-kops-aws-boskos-kubetest2

@justinsb justinsb force-pushed the boskos_kubetest_aws branch from 337188d to a920251 Compare June 22, 2023 18:46
@justinsb
Copy link
Member Author

/test presubmit-kops-aws-boskos-kubetest2

@justinsb justinsb force-pushed the boskos_kubetest_aws branch from a920251 to f7ff12b Compare June 22, 2023 19:15
@justinsb
Copy link
Member Author

/test presubmit-kops-aws-boskos-kubetest2

@justinsb justinsb force-pushed the boskos_kubetest_aws branch from f7ff12b to 8525919 Compare June 22, 2023 19:40
@justinsb
Copy link
Member Author

/test presubmit-kops-aws-boskos-kubetest2

@justinsb justinsb force-pushed the boskos_kubetest_aws branch 2 times, most recently from e79b08c to f9afe5f Compare June 22, 2023 20:18
@justinsb
Copy link
Member Author

/test presubmit-kops-aws-boskos-kubetest2

@justinsb
Copy link
Member Author

@ameukam so I hit some problems with the existing aws-account boskos pool. I got accounts like capa-user-XX (e.g. capa-user-02). I don't think they have access to the shared S3 bucket we were using previously. So I tried having kubetest2-kops create a bucket in each AWS account (GCE does something similar already). However, I think maybe the capa-user-XX accounts don't have S3 access (or I've messed up credentials somewhere, which is definitely plausible :-) )

Maybe we try creating some new accounts in a new boskos pool (e.g. resource-type == kops-aws-account ?), and make sure they have permissions to do S3? Doing separate pools will also help us with tracking back spend (e.g. kops vs capa).

@ameukam
Copy link
Member

ameukam commented Jun 22, 2023

@ameukam so I hit some problems with the existing aws-account boskos pool. I got accounts like capa-user-XX (e.g. capa-user-02). I don't think they have access to the shared S3 bucket we were using previously. So I tried having kubetest2-kops create a bucket in each AWS account (GCE does something similar already). However, I think maybe the capa-user-XX accounts don't have S3 access (or I've messed up credentials somewhere, which is definitely plausible :-) )

Maybe we try creating some new accounts in a new boskos pool (e.g. resource-type == kops-aws-account ?), and make sure they have permissions to do S3? Doing separate pools will also help us with tracking back spend (e.g. kops vs capa).

@justinsb we can use those accounts https://github.com/kubernetes/k8s.io/blob/main/infra/aws/terraform/management-account/organization-accounts-boskos.tf#L17-L42 for kOps. They are currently unused. WDYT ?

@justinsb
Copy link
Member Author

@ameukam that sounds good to me - it's great that they under terraform control because if we do need any other permissions we have a good path forwards. Are they loaded into a boskos pool? Any idea how to select them if so - I think I can select a different resource-type, not sure if there's any other way to select them...

@ameukam
Copy link
Member

ameukam commented Jun 26, 2023

@justinsb They are currently not onboarded. I don't have access to the default cluster. Would be interesting to have a dedicated EKS cluster with a dedicated boskos where can test those changes. That means also move some (or all the) presubmits to this new cluster.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2023
@hakman
Copy link
Member

hakman commented Aug 3, 2023

@justinsb @ameukam Anything new here?

@ameukam
Copy link
Member

ameukam commented Aug 3, 2023

@justinsb @ameukam Anything new here?

Nothing new for the moment. A few things needs to be done on my side.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 17, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@justinsb
Copy link
Member Author

/reopen

Let's discuss some more!

@k8s-ci-robot k8s-ci-robot reopened this Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

@justinsb: Reopened this PR.

In response to this:

/reopen

Let's discuss some more!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@justinsb
kubetest2-kops: add support for boskos-resource-type flag
0d70757 
This will cause AWS tests to acquire an aws-account from boskos (when
set to aws-account), and run the tests with those credentials.
@justinsb
kubetest2-kops: automatically create buckets
f7612c8 
When working with boskos, this means we don't need to have a shared
bucket with dynamic permissions.
@justinsb justinsb force-pushed the boskos_kubetest_aws branch from f9afe5f to f7612c8 Compare November 11, 2024 18:29
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-kops-aws-boskos-kubetest2 f9afe5f link true /test presubmit-kops-aws-boskos-kubetest2
pull-kops-verify-hashes f9afe5f link true /test pull-kops-verify-hashes
pull-kops-e2e-k8s-gce-cilium f7612c8 link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-gce-ipalias f7612c8 link true /test pull-kops-e2e-k8s-gce-ipalias
pull-kops-e2e-k8s-aws-calico f7612c8 link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-e2e-k8s-aws-amazonvpc f7612c8 link true /test pull-kops-e2e-k8s-aws-amazonvpc
pull-kops-verify-gomod f7612c8 link true /test pull-kops-verify-gomod
pull-kops-kubernetes-e2e-ubuntu-gce-build f7612c8 link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rifelpet rifelpet mentioned this pull request Nov 20, 2024
Merged
@ameukam ameukam mentioned this pull request Dec 6, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

@ameukam ameukam Awaiting requested review from ameukam

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinsb @k8s-ci-robot @hakman @ameukam @k8s-triage-robot