Refactor: Split out NLB Listener into its own task #16299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justinsb
force-pushed
the
split_out_loadbalancerlistener
branch
from
c8f6e8f to
3f1dfc7
Compare
k8s-ci-robot
added
needs-rebase
justinsb
force-pushed
the
split_out_loadbalancerlistener
branch
from
3f1dfc7 to
2e0ca41
Compare
k8s-ci-robot
removed
the
needs-rebase
justinsb
force-pushed
the
split_out_loadbalancerlistener
branch
from
2e0ca41 to
47a9d71
Compare
This allows us to use more of our task machinery, including dependency analysis. The intent is that we'll be able to support multiple LoadBalancers and TargetGroups.
Also switch methods that were not passing a context.
justinsb
force-pushed
the
split_out_loadbalancerlistener
branch
from
ae278ab to
c9b9a47
Compare
rifelpet
approved these changes
Feb 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use more of our task machinery, including dependency
analysis. The intent is that we'll be able to support multiple
LoadBalancers and TargetGroups.