Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OptionsBuilder works on kops.Cluster #16768

Merged

Conversation

justinsb
Copy link
Member

Previously it worked on ClusterSpec, but that means we can't read the
labels or annotations. We want to use those labels/annotations to
experiment with new cloud providers (e.g. bare metal) before adding
this to the API.

Introduce generics so we also get type-safety.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2024
@justinsb justinsb force-pushed the make_options_builder_use_cluster branch from b20bcc2 to ef0a6de Compare August 24, 2024 18:11
@justinsb
Copy link
Member Author

I think operation error ec2imds: GetRegion, canceled, context deadline exceeded is unrelated (???)

/retest

@justinsb justinsb force-pushed the make_options_builder_use_cluster branch from ef0a6de to e803153 Compare August 25, 2024 11:49
@hakman
Copy link
Member

hakman commented Aug 25, 2024

/test pull-kops-e2e-cni-cilium-eni
/test pull-kops-e2e-cni-cilium-etcd

@hakman
Copy link
Member

hakman commented Aug 25, 2024

/test pull-kops-e2e-cni-kuberouter
/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-amazonvpc
/test pull-kops-e2e-cni-flannel

Previously it worked on ClusterSpec, but that means we can't read the
labels or annotations.  We want to use those labels/annotations to
experiment with new cloud providers (e.g. bare metal) before adding
this to the API.

Introduce generics so we also get type-safety.
@justinsb justinsb force-pushed the make_options_builder_use_cluster branch from e803153 to 29d6fd8 Compare August 25, 2024 16:58
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2024
@justinsb
Copy link
Member Author

/retest

I am confused as to how this could be failing when initializing DNS, but other jobs are not failing.... retesting one more time to validate my assumptions!

@rifelpet
Copy link
Member

I think the imds error is legitimate and a result of #16647 but I'm not sure why it is happening inconsistently.

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 25, 2024

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-cilium-ipv6 29d6fd8 link false /test pull-kops-e2e-cni-cilium-ipv6
pull-kops-e2e-cni-calico-ipv6 29d6fd8 link false /test pull-kops-e2e-cni-calico-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 388b0a2 into kubernetes:master Aug 25, 2024
29 of 31 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants