metal: assume etcd discovery is external #16814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
justinsb
force-pushed
the
bring_up_etcd
branch
from
3761253 to
2dd033f
Compare
We want to collect the artifacts even if the test fails
Because we now push much larger files, replace our in-memory storage with disk-backed storage.
localhost won't work for multiple nodes and turns out not to even work for one node. Assume that there is a discovery mechanism that sets up /etc/hosts (it might be static configuration). Add to metal test to get to kube-apiserver responding.
justinsb
force-pushed
the
bring_up_etcd
branch
from
2dd033f to
28bd115
Compare
k8s-ci-robot
added
size/XL
|
/test all |
hakman
approved these changes
Sep 12, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localhost won't work for multiple nodes and turns out not to even work for one node.
Assume that there is a discovery mechanism that sets up /etc/hosts (it might be static configuration).
Add to metal test to get to kube-apiserver responding.