Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #16981

Merged
merged 1 commit into from
Dec 6, 2024
Merged

chore: fix some function names in comment #16981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/kops/util/taints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"strings"
)

// parseTaint takes a string and returns a map of its value
// ParseTaint takes a string and returns a map of its value
// it mimics the function from https://github.com/kubernetes/kubernetes/blob/master/pkg/util/taints/taints.go
// but returns a map instead of a v1.Taint
func ParseTaint(st string) (map[string]string, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/model/awsmodel/autoscalinggroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ func (b *AutoscalingGroupModelBuilder) buildSecurityGroups(c *fi.CloudupModelBui
return securityGroups, nil
}

// buildAutoscalingGroupTask is responsible for building the autoscaling task into the model
// buildAutoScalingGroupTask is responsible for building the autoscaling task into the model
func (b *AutoscalingGroupModelBuilder) buildAutoScalingGroupTask(c *fi.CloudupModelBuilderContext, name string, ig *kops.InstanceGroup) (*awstasks.AutoscalingGroup, error) {
t := &awstasks.AutoscalingGroup{
Name: fi.PtrTo(name),
Expand Down
2 changes: 1 addition & 1 deletion pkg/resources/aws/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"k8s.io/kops/upup/pkg/fi/cloudup/awsup"
)

// buildEc2FiltersForCluster returns the set of filters we must use to find all resources
// buildEC2FiltersForCluster returns the set of filters we must use to find all resources
func buildEC2FiltersForCluster(clusterName string) [][]ec2types.Filter {
var filterSets [][]ec2types.Filter

Expand Down
2 changes: 1 addition & 1 deletion protokube/pkg/gossip/dns/provider/zone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (z *zone) ID() string {
return "gossip:" + z.zoneInfo.Name
}

// ResourceRecordsets returns the provider's ResourceRecordSets interface, or false if not supported.
// ResourceRecordSets returns the provider's ResourceRecordSets interface, or false if not supported.
func (z *zone) ResourceRecordSets() (dnsprovider.ResourceRecordSets, bool) {
return &resourceRecordSets{
zone: z,
Expand Down
4 changes: 2 additions & 2 deletions upup/pkg/fi/cloudup/template_functions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ func (tf *TemplateFunctions) KopsControllerEnv() []corev1.EnvVar {
return envMap.ToEnvVars()
}

// OpenStackCCM returns OpenStack external cloud controller manager current image
// OpenStackCCMTag returns OpenStack external cloud controller manager current image
// with tag specified to k8s version
func (tf *TemplateFunctions) OpenStackCCMTag() string {
var tag string
Expand All @@ -918,7 +918,7 @@ func (tf *TemplateFunctions) OpenStackCCMTag() string {
return tag
}

// OpenStackCSI returns OpenStack csi current image
// OpenStackCSITag returns OpenStack csi current image
// with tag specified to k8s version
func (tf *TemplateFunctions) OpenStackCSITag() string {
var tag string
Expand Down
Loading