Do not import github.com/google/go-cmp/cmp outside tests.

Go-cmp relies heavily on reflection in ways that casue the golang compiler to disable the dead code elimination. Even declaring a variable of type cmp.Option disables the DCE. fuzz.go is only used in tests, but is placed in the package itself. This disables the DCE in every user of k8s.io/client-go. Move it to fuzz_test.go instead.
kubernetes · Sep 20, 2023 · b017e20 · b017e20
1 parent 68afd61
commit b017e20
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 1 deletion.
diff --git a/pkg/validation/spec/fuzz.go → pkg/validation/spec/fuzz_test.go b/pkg/validation/spec/fuzz.go → pkg/validation/spec/fuzz_test.go
diff --git a/test/integration/go.mod b/test/integration/go.mod
@@ -18,7 +18,6 @@ require (
 	github.com/go-openapi/swag v0.22.3 // indirect
 	github.com/golang/protobuf v1.5.2 // indirect
 	github.com/google/gnostic-models v0.6.8 // indirect
-	github.com/google/go-cmp v0.5.5 // indirect
 	github.com/google/gofuzz v1.1.0 // indirect
 	github.com/josharian/intern v1.0.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect