Strip/Freeze code from asaskevich/govalidator and drop dependency #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davanum Srinivas <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
|
/approve |
|
/assign @liggitt for pkg/validation/OWNERS approval |
|
/approve |
k8s-ci-robot
added
the
approved
|
+1 to isolate would it make sense to put under https://github.com/kubernetes/kube-openapi/tree/master/pkg/internal/third_party to keep visibility limited and third party things gathered in one spot? |
Signed-off-by: Davanum Srinivas <[email protected]>
|
@liggitt right! we should do that! (Done!) |
liggitt
reviewed
Dec 12, 2024
|
|
||
| // Basic regular expressions for validating strings | ||
| const ( | ||
| CreditCard string = "^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|6(?:011|5[0-9][0-9])[0-9]{12}|3[47][0-9]{13}|3(?:0[0-5]|[68][0-9])[0-9]{11}|(?:2131|1800|35\\d{3})\\d{11})$" |
There was a problem hiding this comment.
| // Basic regular expressions for validating strings | ||
| const ( | ||
| CreditCard string = "^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|6(?:011|5[0-9][0-9])[0-9]{12}|3[47][0-9]{13}|3(?:0[0-5]|[68][0-9])[0-9]{11}|(?:2131|1800|35\\d{3})\\d{11})$" | ||
| ISBN10 string = "^(?:[0-9]{9}X|[0-9]{10})$" |
There was a problem hiding this comment.
| const ( | ||
| CreditCard string = "^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|6(?:011|5[0-9][0-9])[0-9]{12}|3[47][0-9]{13}|3(?:0[0-5]|[68][0-9])[0-9]{11}|(?:2131|1800|35\\d{3})\\d{11})$" | ||
| ISBN10 string = "^(?:[0-9]{9}X|[0-9]{10})$" | ||
| ISBN13 string = "^(?:[0-9]{13})$" |
There was a problem hiding this comment.
| CreditCard string = "^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|6(?:011|5[0-9][0-9])[0-9]{12}|3[47][0-9]{13}|3(?:0[0-5]|[68][0-9])[0-9]{11}|(?:2131|1800|35\\d{3})\\d{11})$" | ||
| ISBN10 string = "^(?:[0-9]{9}X|[0-9]{10})$" | ||
| ISBN13 string = "^(?:[0-9]{13})$" | ||
| Hexcolor string = "^#?([0-9a-fA-F]{3}|[0-9a-fA-F]{6})$" |
There was a problem hiding this comment.
| ISBN10 string = "^(?:[0-9]{9}X|[0-9]{10})$" | ||
| ISBN13 string = "^(?:[0-9]{13})$" | ||
| Hexcolor string = "^#?([0-9a-fA-F]{3}|[0-9a-fA-F]{6})$" | ||
| RGBcolor string = "^rgb\\(\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*,\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*,\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*\\)$" |
There was a problem hiding this comment.
| Hexcolor string = "^#?([0-9a-fA-F]{3}|[0-9a-fA-F]{6})$" | ||
| RGBcolor string = "^rgb\\(\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*,\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*,\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*\\)$" | ||
| Base64 string = "^(?:[A-Za-z0-9+\\/]{4})*(?:[A-Za-z0-9+\\/]{2}==|[A-Za-z0-9+\\/]{3}=|[A-Za-z0-9+\\/]{4})$" | ||
| SSN string = `^\d{3}[- ]?\d{2}[- ]?\d{4}$` |
There was a problem hiding this comment.
| RGBcolor string = "^rgb\\(\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*,\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*,\\s*(0|[1-9]\\d?|1\\d\\d?|2[0-4]\\d|25[0-5])\\s*\\)$" | ||
| Base64 string = "^(?:[A-Za-z0-9+\\/]{4})*(?:[A-Za-z0-9+\\/]{2}==|[A-Za-z0-9+\\/]{3}=|[A-Za-z0-9+\\/]{4})$" | ||
| SSN string = `^\d{3}[- ]?\d{2}[- ]?\d{4}$` | ||
| Int string = "^(?:[-+]?(?:0|[1-9][0-9]*))$" |
There was a problem hiding this comment.
| } | ||
|
|
||
| // IsCreditCard check if the string is a credit card. | ||
| func IsCreditCard(str string) bool { |
There was a problem hiding this comment.
|
|
||
| // IsISBN check if the string is an ISBN (version 10 or 13). | ||
| // If version value is not equal to 10 or 13, it will be check both variants. | ||
| func IsISBN(str string, version int) bool { |
There was a problem hiding this comment.
| } | ||
|
|
||
| // ToInt convert the input string or any int type to an integer type 64, or 0 if the input is not an integer. | ||
| func ToInt(value interface{}) (res int64, err error) { |
There was a problem hiding this comment.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Jefftree, liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #512 for context.
Notes:
github.com/asaskevich/govalidator