Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field status.hostIPs added for Pod #109616

Merged
merged 12 commits into from
Jul 15, 2023
Merged

Field status.hostIPs added for Pod #109616

merged 12 commits into from
Jul 15, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Apr 22, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/sig node
/sig network

What this PR does / why we need it:

kubernetes/enhancements#2661
If the Pod runs on an enabled IPv6 dual stack node, hope to get the IPv6 address of node

Which issue(s) this PR fixes:

Original PR #101566
Fixes #101565
Fixes #85443

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Alpha support for the field `status.hostIPs` was added to the Pod API, and downward API support for `status.hostIPs` as added. To use either, the alpha feature gate `PodHostIPs` is required to be enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/2661
- [Website PR]: https://github.com/kubernetes/website/pull/42003

@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2022
@k8s-ci-robot k8s-ci-robot added area/code-generation area/kubelet area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 22, 2022
@wzshiming
Copy link
Member Author

wzshiming commented Apr 22, 2022 •
edited
Loading

Types conversion
8e34771

Add dropDisabledStatusFields
b3a82c6

Add HostIPs by Kubelet
ac9d720

I think the reason why the original load is too large is that, it should be that when Feature is disabled, the Conversion section fills HostIPs and then discards in DropDisableDStatusfields.
Remove the Conversion it should be avoided.

I guess it is enough to fill Hostips by Kubelet when enabling features.

@wzshiming
Copy link
Member Author

/cc @liggitt
/cc @thockin

@k8s-ci-robot k8s-ci-robot requested review from liggitt and thockin April 22, 2022 12:08
@liggitt
Copy link
Member

liggitt commented Apr 25, 2022

is there a specific delta that shows the differences between this PR and the original? are there added tests that would have caught the issues with the previous PR?

@wzshiming wzshiming force-pushed the feat/pod-host-ips branch from aa3aa91 to 3e2a1a7 Compare July 14, 2023 01:44
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin July 14, 2023 01:44
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2023
@wzshiming
Copy link
Member Author

Hi, @thockin
PTAL again, it just rebases and ./hack/update-codegen.sh

thockin
thockin reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f5201924c056fd954a946b49696edd91cfbbccbe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wzshiming
Copy link
Member Author

wzshiming commented Jul 15, 2023 •
edited
Loading

Thanks
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8a0ea1b into kubernetes:master Jul 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 15, 2023
@wzshiming wzshiming deleted the feat/pod-host-ips branch July 15, 2023 08:34
@pacoxu
Copy link
Member

pacoxu commented Jul 17, 2023 •
edited
Loading

https://perf-dash.k8s.io/#/?jobname=kubemark-500Nodes&metriccategoryname=E2E&metricname=LoadHighThroughputPodStartup&Metric=pod_startup

No performance regression this time. 🎉

@danwinship danwinship mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@thockin thockin thockin left review comments

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.28
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

[Feature request] Field status.hostIPs added for Pod DualStack: Support pod env source get host IPV6