Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize: migrate presubmits to community clusters #29733

Merged
merged 5 commits into from
Jun 17, 2023
Merged

kustomize: migrate presubmits to community clusters #29733

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6de6228
Add the new cluster key to remove default
Jun 8, 2023
7664518
Add resource requests/limits for community owned cluster
Jun 9, 2023
5f6ad86
Update cpu memory in kustomize-presubmit-master.yaml
Jun 15, 2023
362bfb0
Remove trailing spaces
Jun 16, 2023
fde4097
Remove trailing whitespace
Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions config/jobs/kubernetes-sigs/kustomize/kustomize-presubmit-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
presubmits:
kubernetes-sigs/kustomize:
- name: kustomize-presubmit-master
cluster: eks-prow-build-cluster
decorate: true
always_run: true
path_alias: sigs.k8s.io/kustomize
Expand All @@ -15,7 +16,11 @@ presubmits:
- prow-presubmit-check
resources:
requests:
memory: "2000Mi"
cpu: 4000m
limits:
memory: "2000Mi"
cpu: 4000m
Copy link
Contributor

@rjsadow rjsadow Jun 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is erroring on the trailing white space after the 4000m.

cpu: 4000m 

config/jobs/kubernetes-sigs/kustomize/kustomize-presubmit-master.yaml
  23:23     error    trailing spaces  (trailing-spaces)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I have remove d the trailing space, How are you seeing that this was the error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is still some trailing whitespace after the CPU. You can look at the log that the k8s-ci-robot provides or from the job itself. Here's the link to the job logs https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/29733/pull-test-infra-verify-lint/1669558900354977792. In there if you just search for "error" you'll find the offending line(s).

annotations:
testgrid-dashboards: sig-cli-misc
testgrid-tab-name: kustomize-presubmit-master
Expand Down