fix node feature failures #34179
fix node feature failures #34179
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/config
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/testing
| @@ -380,7 +380,7 @@ periodics: | |||
| - '--node-test-args=--container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/home/containerd/usr/local/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service"' | |||
| - --node-tests=true | |||
| - --provider=gce | |||
| - --test_args=--nodes=8 --focus="\[Feature:.+\]|\[Feature\]" --skip="\[Flaky\]|\[Serial\]|\[Feature:InPlacePodVerticalScaling\]|\[Feature:UserNamespacesSupport\]|\[Feature:PodLifecycleSleepActionAllowZero\]|\[Feature:UserNamespacesPodSecurityStandards\]|\[Feature:KubeletCredentialProviders\]|\[Feature:LockContention\]|\[Feature:SCTPConnectivity\]" | |||
| - --test_args=--nodes=8 --focus="\[Feature:.+\]|\[Feature\]" --skip="\[Flaky\]|\[Serial\]|\[Feature:InPlacePodVerticalScaling\]|\[Feature:UserNamespacesSupport\]|\[Feature:UserNamespacesStatelessPodsSupport\]|\[Feature:PodLifecycleSleepActionAllowZero\]|\[Feature:UserNamespacesPodSecurityStandards\]|\[Feature:KubeletCredentialProviders\]|\[Feature:LockContention\]|\[Feature:SCTPConnectivity\]" | |||
There was a problem hiding this comment.
How are these currently passing if they were meant to be skipped 🤔
There was a problem hiding this comment.
We want to get rid of NodeFeature and use Feature as a tag for features. These jobs were labeled as Feature so I think they were skipped before (we used NodeFeature before)
There was a problem hiding this comment.
This is what caused my confusion. 3 of them were passing in https://testgrid.k8s.io/sig-node-containerd#containerd-node-e2e-features-1.6
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@kannon92: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #kubernetes/kubernetes#129695