Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guide add #26

Closed
wants to merge 7 commits into from
Closed

Contributing guide add #26

wants to merge 7 commits into from

Conversation

shivam-sharma7
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan linked an issue May 2, 2022 that may be closed by this pull request
@anubha-v-ardhan anubha-v-ardhan added the hold Wait, please do not proceed this yet label May 2, 2022
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AvineshTripathi
Copy link
Collaborator

LGTM

p.s. if anything needs to be added or removed, suggestions are always welcome

@verma-kunal
Copy link
Collaborator

Hey @shivam-sharma7 , this looks good! I do think we can make this a bit more informative for beginner folks out there, by adding more information like how to commit, how to make a change, how to push etc.
You can take reference from the guide here (from another repo) & see if you can add some more steps to our guide!

Let me know your thoughts on this or any questions :)
cc @AvineshTripathi @anubha-v-ardhan @saiyam1814

@AvineshTripathi
Copy link
Collaborator

do you want to add in this PR or have a seperate one

CONTRIBUTING.md Outdated Show resolved Hide resolved
@verma-kunal
Copy link
Collaborator

Hey @anubha-v-ardhan , is this PR good to go or have any other changes needs to be done?
cc @shivam-sharma7 @AvineshTripathi

Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove changes on README from this PR as it's already being handled by #36. Committing changes on README via this PR will create conflicts.
This is also why I added the hold label.

@anubha-v-ardhan
Copy link
Contributor

anubha-v-ardhan commented May 14, 2022

Hey @anubha-v-ardhan , is this PR good to go or have any other changes needs to be done? cc @shivam-sharma7 @AvineshTripathi

I was thinking if we can do a more detailed contributing guide dividing it into two sections for core website work and notes work since notes will also be on website repo. But since it's not clear yet how the notes work will proceed, I think we can merge this removing hold once #26 (review) is resolved and make issue for enhancing this guide later.

@anubha-v-ardhan
Copy link
Contributor

@shivam-sharma7 Please comment on #2 and get it assigned to yourself to avoid confusion. Always notify everyone by commenting on the issue before you start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contributing guide for website
5 participants