-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing guide add #26
Conversation
shivam-sharma7
commented
May 2, 2022
- Fixed issue Add Contributing guide for website #2
LGTM p.s. if anything needs to be added or removed, suggestions are always welcome |
Hey @shivam-sharma7 , this looks good! I do think we can make this a bit more informative for beginner folks out there, by adding more information like Let me know your thoughts on this or any questions :) |
do you want to add in this PR or have a seperate one |
Hey @anubha-v-ardhan , is this PR good to go or have any other changes needs to be done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove changes on README from this PR as it's already being handled by #36. Committing changes on README via this PR will create conflicts.
This is also why I added the hold
label.
I was thinking if we can do a more detailed contributing guide dividing it into two sections for core website work and notes work since notes will also be on website repo. But since it's not clear yet how the notes work will proceed, I think we can merge this removing |
@shivam-sharma7 Please comment on #2 and get it assigned to yourself to avoid confusion. Always notify everyone by commenting on the issue before you start working on it. |