-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML 1.2 Test Case Generator #19
base: main
Are you sure you want to change the base?
Conversation
Fixed references to 'field_type' being renamed to 'type' Checked all tests now pass
…ed by the 1.2 YAML test cases and autogenerates zig test cases
…which contains the tests
Updated the tests to the improved format as suggested.
Updated Readme to include information about tests Fixed missing error return for cases that we expect success on
…===' file as a comment header. This will also be useful in future failure messages.
… generating only specific tests to run against, which should help reduce the amount of excess messages when running the test cases.
…effectively supresses the call stack report on error and just logs success/failure as a one liner. Allows for quicker review of pass/fail
Looks like there are some formatting issues in |
Ah, yes I had the formatter off. I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta for this. Reminds me I need to enable the formatter again
I see that the CI is trying to run the spec tests even though we haven't provided any: https://github.com/kubkon/zig-yaml/actions/runs/4096254949/jobs/7084964904#step:6:5 I see two possible solutions here: 1) we make the spec test part of this repo via submodule or otherwise, or 2) we add a conditional build flag such as Also, if you decide to go with the latter, here's an example of how something similar is being done for the Zig compiler itself: https://github.com/ziglang/zig/blob/a5b34a61ab61882bf55d87e4cbc8186215ecf320/build.zig#L106 If you follow all callsites of this variable, you will hopefully get a good idea how it's architected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the top-level comments for what needs to be done next.
Cheers, I will have a look at the next opportunity :) |
Build file seeems to be working but i don't think the .test CompileStep works anymore. bug?
Updated test module dependencies and set kind to correct enum variant
begins the process of resolving #16