Skip to content

Commit

Permalink
improve e2e tests when checking for warn or error strings
Browse files Browse the repository at this point in the history
  • Loading branch information
xmik committed Oct 25, 2020
1 parent e525069 commit 8c0aa2b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Verify if Bash is installed when running Dojo. Dojo performs a shell out and Bash is its dependency. If Bash is not installed, a pretty error will be printed. [#22](https://github.com/kudulab/dojo/issues/22)
* Use newer pytest version 6.1.1, was 4.4.1
* Improve e2e tests output - print stdout and stderr on failure
* Improve e2e tests when checking for warn or error strings

### 0.10.0 (2020-Sep-06)

Expand Down
6 changes: 2 additions & 4 deletions test/support/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,5 @@ def run_dojo_and_set_bash_func(args, env=None):


def assert_no_warnings_or_errors(text, full_output_to_print):
assert not 'warn' in text, full_output_to_print
assert not 'error' in text, full_output_to_print
assert not 'WARN' in text, full_output_to_print
assert not 'ERROR' in text, full_output_to_print
assert not 'warn' in text.lower(), full_output_to_print
assert not 'error' in text.lower(), full_output_to_print

0 comments on commit 8c0aa2b

Please sign in to comment.