-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meshservice: Enable linking of Outbounds in DataPlaneViz to MeshService detail page #2848
Comments
|
PR to not display the link for now: |
During parsing of the Envoy stats responses, if we find a clustername with `_msvc_` (or related), we mark that cluster/outbound as having a `kind` of `MeshService`. Later on in the view, we can decide whether to add a link to the cards service depending on its `kind`. Currently we only link cards with empty kinds. i.e. if its not a MeshService, MeshMultiZoneService or a MeshExternalService we don't link the card. See linked issue for more details #2848 Signed-off-by: John Cowen <[email protected]>
FYI #2853 is in, I'm guessing we just need to bump the milestone here seeing as it sounds like we need backend support which won't come until after the upcoming release (see triage comment) I'll leave 2.9 for now but guessing we can bump that when the milestone gets reviewed. |
@johncowen to search for a backend issue to relate to this. |
@jakubdyszkiewicz do you have any insight on the backend work related to this issue? Not sure if there is already an issue, or whether you had any thoughts on whats required for the backend support we need for this? |
@johncowen is this what you are looking for: kumahq/kuma#11865 |
I don't think so but not totally sure, shall we remove the accepted label so we can discuss in triage? I won't be working this until way after the next triage anyway. If not, we could also just chat through this next time we sync. |
|
Description
For the dataplane overview viz we use Envoy stats as the data source to generate the viz/GUI, current this generates the following Outbounds:
The links here take us to the following URL:
http://localhost:5681/gui/meshes/default/data-planes?s=service:demo-app_kuma-demo_msvc_5000
i.e. Show me the list of dataplanes that have the
kuma.io/service
equallingdemo-app_kuma-demo_msvc_5000
, which of course don't exist. Therefore we show an empty list.The cards in the above screenshot should instead read (ideally)
demo-app
, and link to:http://localhost:5681/gui/meshes/default/services/mesh-services/demo-app.kuma-demo/overview
Note: In some environments the name used in the above screenshot can contain the hash used for identifying dataplanes in the backend i.e.
redis-2a3s4d5f_kuma-demo_msvc_5000
.Overall this presents a problem because it "looks like" we can only use
-
and_
as separators/markers, which are also valid user values, meaning any sort of parsing/regexing we do is not going to be guaranteed to work correctly.The text was updated successfully, but these errors were encountered: