feat(dataplanes): disable linking of new Mesh*Services #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
feat/disable-msvc-linking
branch
from
919b371
to
233153f
Compare
michaelbeaumont
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During parsing of the Envoy stats responses, if we find a clustername with
_msvc_(or related), we mark that cluster/outbound as having akindofMeshService.Later on in the view, we can decide whether to add a link to the cards service depending on its
kind.Currently we only link cards with empty kinds. i.e. if its not a MeshService, MeshMultiZoneService or a MeshExternalService we don't link the card.
See linked issue for more details #2848