-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from github.com/golang/protobuf/ptypes to google.golang.org/protobuf/types/known #10023
base: master
Are you sure you want to change the base?
Conversation
0f15108
to
a9872b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't merge it
go.mod
Outdated
@@ -13,7 +13,7 @@ require ( | |||
github.com/containernetworking/cni v1.1.2 | |||
github.com/containernetworking/plugins v1.4.1 | |||
github.com/emicklei/go-restful/v3 v3.12.0 | |||
github.com/envoyproxy/go-control-plane v0.12.0 | |||
github.com/envoyproxy/go-control-plane v0.12.1-0.20240419124334-0cebb2f428b3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lobkovilya can we do it? I think replace won't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the replace won't work in this case, I checked locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jakub is blocking this so setting a request changes to avoid accidental merge
a0a42a1
to
5343197
Compare
…rotobuf/types/known Signed-off-by: Matthieu MOREL <[email protected]>
migrate from
github.com/golang/protobuf/ptypes
togoogle.golang.org/protobuf/types/known
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --