ci: improved the CI/CD scripts

kurone-kito · Oct 10, 2024 · 68792c4 · 68792c4
1 parent d6ba61f
commit 68792c4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/build-listing.yml b/.github/workflows/build-listing.yml
@@ -48,7 +48,7 @@ jobs:
           path: ${{ env.pathToCi }}
           clean: false
       - name: Deploy the global.json file
-        run: cp ${{ github.workspace }}/global.json ${{ env.pathToCi }}/
+        run: cp "${{ github.workspace }}/global.json" "${{ env.pathToCi }}/"
       - name: Load cached data from previous runs
         uses: actions/cache@v4
         with:
@@ -57,7 +57,7 @@ jobs:
             ~/.nuget/packages
           key: ${{ runner.os }}-${{ hashFiles('**/global.json', '**/*.csproj') }}
       - name: Build Package Version Listing with Nuke
-        run: ${{ env.pathToCi }}/build.cmd BuildRepoListing --root ${{ env.pathToCi }} --list-publish-directory $GITHUB_WORKSPACE/${{ env.listPublishDirectory }} --current-package-name ${{ vars.PACKAGE_NAME }}
+        run: '"${{ env.pathToCi }}/build.cmd" BuildRepoListing --root "${{ env.pathToCi }}" --list-publish-directory "$GITHUB_WORKSPACE/${{ env.listPublishDirectory }}" --current-package-name "${{ vars.PACKAGE_NAME }}"'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Prepare for GitHub Pages deployment

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -23,10 +23,10 @@ jobs:
           echo "unityPackage=${{ vars.PACKAGE_NAME }}-feature.unitypackage" >> $GITHUB_ENV
           echo "zipFile=${{ vars.PACKAGE_NAME }}-feature.zip" >> $GITHUB_ENV
       - name: Zip the Package for testing
-        working-directory: "${{ env.packagePath }}"
         run: zip -r "${{ github.workspace }}/${{ env.zipFile }}" .
+        working-directory: "${{ env.packagePath }}"
       - name: Build a list of .meta files for future use
-        run: find "${{ env.packagePath }}/" -name \*.meta >> metaList
+        run: find "${{ env.packagePath }}/" -name '*.meta' -type f >> metaList
       - name: Make a UnityPackage version of the Package for release
         uses: pCYSl5EDgo/create-unitypackage@v1
         with:
@@ -39,7 +39,7 @@ jobs:
           path: ${{ env.pathToCi }}
           clean: false
       - name: Deploy the global.json file
-        run: cp ${{ github.workspace }}/global.json ${{ env.pathToCi }}/
+        run: cp "${{ github.workspace }}/global.json" "${{ env.pathToCi }}/"
       - name: Load cached data from previous runs
         uses: actions/cache@v4
         with:
@@ -48,6 +48,6 @@ jobs:
             ~/.nuget/packages
           key: ${{ runner.os }}-${{ hashFiles('**/global.json', '**/*.csproj') }}
       - name: Build Package Version Listing with Nuke
-        run: ${{ env.pathToCi }}/build.cmd BuildRepoListing --root ${{ env.pathToCi }} --list-publish-directory $GITHUB_WORKSPACE/${{ env.listPublishDirectory }} --current-package-name ${{ vars.PACKAGE_NAME }}
+        run: '"${{ env.pathToCi }}/build.cmd" BuildRepoListing --root "${{ env.pathToCi }}" --list-publish-directory "$GITHUB_WORKSPACE/${{ env.listPublishDirectory }}" --current-package-name "${{ vars.PACKAGE_NAME }}"'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -62,10 +62,10 @@ jobs:
           echo "version=${{ steps.version.outputs.value }}" >> $GITHUB_ENV
           echo "zipFile=${{ vars.PACKAGE_NAME }}-${{ steps.version.outputs.value }}.zip" >> $GITHUB_ENV
       - name: Zip the Package for release
-        working-directory: "${{ env.packagePath }}"
         run: zip -r -9 "${{ github.workspace }}/${{ env.zipFile }}" .
+        working-directory: "${{ env.packagePath }}"
       - name: Build a list of .meta files for future use
-        run: find "${{ env.packagePath }}/" -name \*.meta >> metaList
+        run: find "${{ env.packagePath }}/" -name '*.meta' -type f >> metaList
       - name: Make a UnityPackage version of the Package for release
         uses: pCYSl5EDgo/create-unitypackage@v1
         with: