encodings: decode utf-8 with errors='replace' when confident #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Confident" means "metadata of the document explicitly indicates that the encoding is UTF-8".
Background of the patch
When a UTF-8 feed has a few invalid characters but the rest is fine, feedparser will only parse it as
iso-8859-2
(or other encodings detected bychardet
, if installed), even if both the HTTP and XML headers explicitly indicate that its encoding isutf-8
.To handle it better, we should decode the feed as UTF-8 with
errors='replace'
.