This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
fix: fix gradual memory leak / perf issue with cytoscape #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylarmb
commented
Sep 27, 2024
| const stopPolling = () => { | ||
| clearInterval(timerRef.current!); | ||
| timerRef.current = null; | ||
| }; |
There was a problem hiding this comment.
the TLDR of the change here is that the timer now uses a useRef instead of a useEffect, which has different behavior in regards to re-renders
laurentluce
approved these changes
Sep 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where the topology graph page gradually becomes laggy and increases memory usage over time. This was because the interval timer was implemented in a way that caused the graph to re-render on every execution, and there was an issue where the loading state changing in the API context caused an additional re-render. This added up to 2 re-renders per second that were not needed. Why a re-render with the same input props causes the Cytoscape library to leak memory? I am not sure, but that is beyond the scope of this as the root cause is likely deep within the Cytoscape library. The best we can do is limit renders to only happening as needed.