PR review changes

kurtosis-tech · Oct 24, 2023 · 9279fcf · 9279fcf
1 parent adb0594
commit 9279fcf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.../lib/backend_impls/docker/object_attributes_provider/docker_label_key/docker_label_key.go b/.../lib/backend_impls/docker/object_attributes_provider/docker_label_key/docker_label_key.go
@@ -3,6 +3,7 @@ package docker_label_key
 import (
 	"github.com/kurtosis-tech/stacktrace"
 	"regexp"
+	"strings"
 )
 
 const (
@@ -61,7 +62,8 @@ func (key *DockerLabelKey) GetString() string {
 }
 
 func validateNotEmptyUserCustomLabelKey(str string) error {
-	if str == "" || str == " " {
+	str = strings.TrimSpace(str)
+	if str == "" {
 		return stacktrace.NewError("User custom label key can't be an empty string")
 	}
 	return nil

diff --git a/..._impls/kubernetes/object_attributes_provider/kubernetes_label_key/kubernetes_label_key.go b/..._impls/kubernetes/object_attributes_provider/kubernetes_label_key/kubernetes_label_key.go
@@ -53,7 +53,8 @@ func (key *KubernetesLabelKey) GetString() string {
 }
 
 func validateNotEmptyUserCustomLabelKey(str string) error {
-	if str == "" || str == " " {
+	str = strings.TrimSpace(str)
+	if str == "" {
 		return stacktrace.NewError("User custom label key can't be an empty string")
 	}
 	return nil