Skip to content

Commit

Permalink
start errors with capital letters
Browse files Browse the repository at this point in the history
  • Loading branch information
h4ck3rk3y committed Oct 13, 2023
1 parent 534ed23 commit d64f6cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ func CreateEngine(
) {
hasNodes, err := kubernetesManager.HasComputeNodes(ctx)
if err != nil {
return nil, stacktrace.Propagate(err, "an error occurred while verifying whether the Kubernetes cluster has any compute nodes")
return nil, stacktrace.Propagate(err, "An error occurred while verifying whether the Kubernetes cluster has any compute nodes")
}
if !hasNodes {
return nil, stacktrace.NewError("can't start engine on the Kubernetes cluster as it has no compute nodes")
return nil, stacktrace.NewError("Can't start engine on the Kubernetes cluster as it has no compute nodes")
}

engineGuidStr, err := uuid_generator.GenerateUUIDString()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1732,7 +1732,7 @@ func (manager *KubernetesManager) GetExecStream(ctx context.Context, pod *apiv1.
func (manager *KubernetesManager) HasComputeNodes(ctx context.Context) (bool, error) {
nodes, err := manager.kubernetesClientSet.CoreV1().Nodes().List(ctx, metav1.ListOptions{})

Check failure on line 1733 in container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go

View workflow job for this annotation

GitHub Actions / golang-lint

TypeMeta, LabelSelector, FieldSelector, Watch, AllowWatchBookmarks, ResourceVersion, ResourceVersionMatch, TimeoutSeconds, Limit, Continue, SendInitialEvents are missing in ListOptions (exhaustruct)
if err != nil {
return false, stacktrace.Propagate(err, "an error occurred while checking if the Kubernetes cluster has any nodes")
return false, stacktrace.Propagate(err, "An error occurred while checking if the Kubernetes cluster has any nodes")
}
return len(nodes.Items) != 0, nil
}
Expand Down

0 comments on commit d64f6cb

Please sign in to comment.