Add validation for case where port is specified without service

kurtosis-tech · Nov 28, 2023 · fd746f9 · fd746f9
1 parent 5f061a7
commit fd746f9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/portal/daemon/port_forward_manager/port_forward_manager.go b/portal/daemon/port_forward_manager/port_forward_manager.go
@@ -117,6 +117,10 @@ func validateCreateUserServicePortForwardArgs(enclaveServicePort EnclaveServiceP
 		return stacktrace.NewError("EnclaveId is always required but we received an empty string")
 	}
 
+	if enclaveServicePort.ServiceId() == "" && enclaveServicePort.PortId() != "" {
+		return stacktrace.NewError("PortId (%v) was specified without a corresponding ServiceId", enclaveServicePort.PortId())
+	}
+
 	if requestedLocalPort != 0 {
 		if enclaveServicePort.ServiceId() == "" || enclaveServicePort.PortId() == "" {
 			return stacktrace.NewError("A static port '%d' was requested, but enclaveId, serviceId, and portId were not all specified: %v", requestedLocalPort, enclaveServicePort)