fix: set parallelism to 4 when its passed as 0 #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenmarchetti
approved these changes
Oct 9, 2023
tedim52
pushed a commit
that referenced
this pull request
Oct 10, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.4](0.84.3...0.84.4) (2023-10-10) ### Features * Always keep latest released version of Kurtosis images ([#1473](#1473)) ([7fbdfd0](7fbdfd0)) * make clean -a remove all logs ([#1517](#1517)) ([3ec7d88](3ec7d88)) ### Bug Fixes * check docker engine is prior to linting and give a useful error when it is not ([#1506](#1506)) ([542d435](542d435)) * set parallelism to 4 when its passed as 0 ([#1502](#1502)) ([4af67d5](4af67d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The frontend is passing 0 as parallelism instead of 4 as the default; setting it to 4 in the backend for now. Someone better than me at frontend can fix the frontend bug; I spent some time looking into connect/enclave-manager/frontend inside engine and gave up
Is this change user facing?
YES - fixes cloud runs of things that use
add_services