feat: Add create enclave utils to SDK #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorcolombo
requested review from
leoporoli and
h4ck3rk3y
and removed request for
leoporoli
|
It's unclear for me if this makes sense in TypeScript, since it doesn't feel very idiomatic |
h4ck3rk3y
approved these changes
Oct 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.7](0.84.6...0.84.7) (2023-10-16) ### Features * Add create enclave utils to SDK ([#1550](#1550)) ([eb952bb](eb952bb)) * provide granular progress of starlark package run ([#1548](#1548)) ([8b20031](8b20031)) * rename kurtosis context "switch" to "set" ([#1537](#1537)) ([ccff275](ccff275)) ### Bug Fixes * propagate unexpected test errors via the test framework ([#1559](#1559)) ([c463ae2](c463ae2)) * show container status instead of service status in enclave inspect ([#1560](#1560)) ([3e1208b](3e1208b)), closes [#1351](#1351) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A very idiomatic pattern in Go is to use
deferand closer functions to cleanup resources, instead of relying on memory to call the correct SDK calls when the test/setup is done. This is very common on our test suit that we have a util, that now is exposed to an external user.This PR also introduces a single SDK call to get from starlark to enclave, something that was not possible before.
Is this change user facing?
YES
References (if applicable):
#1152