feat: support deletion in the new enclave manager ui #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description: Add support for creating enclaves in the new EM ui. The major changes in this PR are: * Support for reading specified packages from the package indexer * Support for rendering forms from lists of `PackageArg` values using `react-hook-form` to manage state, and chakra components for UI. * Support for executing starlark with fresh enclave configuration. * Support for dumping the list of cataloged packages into the packages screen. ### Demo https://github.com/kurtosis-tech/kurtosis/assets/4419574/ecbfd851-aa82-4c88-80da-19b06be1600e ## Is this change user facing? NO, the new em ui is not currently used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for enclave deletion to the new enclave manager ui. The delete action is handled in a react router action on the /enclaves path.
This PR also includes a change to the loaders to use
deferso that loading states can be displayed with suspense - https://reactrouter.com/en/main/guides/deferred.Demo
The positioning of the modal is a little off due to my screen size - it is centered on the window
deletion.mp4
Is this change user facing?
NO (this ui is not currently deployed
References (if applicable):
This PR sits on top of #1643