Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enclave ui feedback implementation #1725

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

Dartoxian
Copy link
Contributor

Description:

This PR implements all burdown feedback for:

  • Enclave list view (make clickable cells work properly, make headers highlightable when sortable, image names clickable, make non clickable styles work with correct styling)
  • Enclave overview (remove source tab, fix cell interactivity in table for ports, merge public private ports in popover, drop ports timeout)
  • Enclave logs (link to existing issue rather than suggesting make a new issue)
  • Service view (fix monaco scrolling, remove delete/edit buttons, merge public/private ports)
  • Enclave configuration (copy updates, but not json field update).

Is this change user facing?

YES

References (if applicable):

@Dartoxian Dartoxian requested a review from adschwartz November 8, 2023 18:36
@adschwartz adschwartz merged commit 5f32f75 into feat/download-files Nov 8, 2023
15 checks passed
@adschwartz adschwartz deleted the fix/enclave-list-feedback branch November 8, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants