feat: improve logging part 1 #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description: This PR implements all burdown feedback for: * Enclave list view (make clickable cells work properly, make headers highlightable when sortable, image names clickable, make non clickable styles work with correct styling) * Enclave overview (remove source tab, fix cell interactivity in table for ports, merge public private ports in popover, drop ports timeout) * Enclave logs (link to existing issue rather than suggesting make a new issue) * Service view (fix monaco scrolling, remove delete/edit buttons, merge public/private ports) * Enclave configuration (copy updates, but not json field update). ## Is this change user facing? YES ## References (if applicable): * https://www.notion.so/kurtosistech/FE-Devconnect-Work-breakdown-af548547e0ec4a4996f75205a4fcbd60#b9f4e5a71aad4347827473e72bc888b2
tedim52
reviewed
Nov 9, 2023
enclave-manager/web/src/components/enclaves/tables/FilesTable.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # engine/server/webapp/asset-manifest.json # engine/server/webapp/index.html # engine/server/webapp/static/js/main.0e475410.js.LICENSE.txt # engine/server/webapp/static/js/main.0e475410.js.map # engine/server/webapp/static/js/main.9849104e.js.LICENSE.txt # engine/server/webapp/static/js/main.9849104e.js.map # engine/server/webapp/static/js/main.f0942104.js.LICENSE.txt # engine/server/webapp/static/js/main.f0942104.js.map
tedim52
approved these changes
Nov 9, 2023
added 2 commits
November 9, 2023 09:38
Dartoxian
approved these changes
Nov 9, 2023
enclave-manager/web/src/emui/enclaves/enclave/service/logs/ServiceLogs.tsx
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.10](0.85.9...0.85.10) (2023-11-09) ### Features * add download artifacts endpoint to enclave manager ([#1730](#1730)) ([3909d5c](3909d5c)) * improve logging part 1 ([#1728](#1728)) ([8f631ae](8f631ae)) * new emui use monaco as json editor ([#1733](#1733)) ([298a0a2](298a0a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
<enclave-name>--<service-name>-logs.txtIs this change user facing?
YES
References (if applicable):