Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Implement logs navigation feedback #1837

Closed
wants to merge 2 commits into from
Closed

chore: Implement logs navigation feedback #1837

wants to merge 2 commits into from

Conversation

Dartoxian
Copy link
Contributor

Description:

This PR implements the feedback left on #1830 for the logs navigation changes. Additionally it:

  • fixes the bug in the ctrl+f listener which calls it to block ctrl+f on all pages that are not logs related after first navigation
  • implements regex error handling
  • styles the buttons consistently and fixes the alignment of the 'matches' info text.

image

image

Is this change user facing?

YES

@Dartoxian Dartoxian requested a review from adschwartz November 21, 2023 11:36
@Dartoxian
Copy link
Contributor Author

Closing this PR as the change will be included in bgazzard/emui-additions

@Dartoxian Dartoxian closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adschwartz adschwartz Awaiting requested review from adschwartz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dartoxian