feat: emui package details page #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Nov 30, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.39](0.85.38...0.85.39) (2023-11-30) ### Features * emui package details page ([#1873](#1873)) ([e2b75b2](e2b75b2)) * User service ports Traefik Docker labels ([#1871](#1871)) ([d18f20e](d18f20e)) ### Bug Fixes * move log collector creation logic ([#1870](#1870)) ([b695e27](b695e27)) * service name collision error message ([#1863](#1863)) ([164b316](164b316)) * Update custom Nix dev deps to work on also linux ([#1862](#1862)) ([d11cd37](d11cd37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the emui package details page.
The change @adschwartz to refactor keyboard listener code requested in #1865 is also included.
It also fixes the poor rendering of the catalog logos on chrome.
Additionally it implements feedback Tise left on the designs for me to pick up, specifically:
Finally, quite a large addition is included to support the combination of
react-markdownandchakrain theKurtosisMarkdowncomponent which includes basic chakra implementations of the html components. This is required becauseCSSReset(part of chakra theme) unsets all of the styling that would apply to markdown.Short demo
packageDetails.mp4
Is this change user facing?
YES
References (if applicable):