fix: change tail package #1874
Merged
fix: change tail package #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
commented
Nov 30, 2023
...ntralized_logs/client_implementations/persistent_volume/log_file_manager/log_file_manager.go
Show resolved
Hide resolved
tedim52
force-pushed
the
tedi/hpcloud
branch
2 times, most recently
from
17d4032 to
11add55
Compare
adschwartz
reviewed
Dec 1, 2023
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Outdated
Show resolved
Hide resolved
adschwartz
reviewed
Dec 1, 2023
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Show resolved
Hide resolved
adschwartz
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
@tedim52 overall ok, but I have a question regarding the cost of testing the JSON string
adschwartz
approved these changes
Dec 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.40](0.85.39...0.85.40) (2023-12-02) ### Features * change change license to Apache 2.0 ([#1884](#1884)) ([64084d8](64084d8)) ### Bug Fixes * cache bug ([#1885](#1885)) ([82e46e2](82e46e2)) * change tail package ([#1874](#1874)) ([f4e87ec](f4e87ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When logs were being produced at a rate of greater than 200-300 logs per second, the
nxadm/tailwould be returning incomplete lines, causing parsing errors on tailed logs. Switching to usinghpcloud/tailfixes this completely when I ran several tests with >1000 logs per second. (the apis are identically andhpcloud/tailseems to be more widely used) In case this package also fails, I've changd the logic return err immediately.Is this change user facing?
NO
References
#1843