Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: service logs full download #1895

Merged
merged 6 commits into from
Dec 7, 2023
Merged

feat: service logs full download #1895

merged 6 commits into from
Dec 7, 2023

Conversation

Dartoxian
Copy link
Contributor

Description:

This PR implements the full streamed download of service logs. This is based on some work already done by @tedim52 in tedi/copydownload.

Changes:

  • The copy logs button is no longer available on the Service Logs page
  • The download logs button sends the log stream to a stream writer to download them as a file.

Concerns:

  • For services that log excessively, like the log spammer, it seems downloading the logs is incredibly slow - <1kb/s. I'm not sure what could improve this, but if the backend streamed more than one record per message (as seems to be possible by the api spec) that seems like it would help (and would help improve performance when rendering service logs in the ui).

Demo

downloadServiceLogs.mp4

Is this change user facing?

YES

@Dartoxian Dartoxian requested a review from adschwartz December 5, 2023 16:59
@Dartoxian Dartoxian added this pull request to the merge queue Dec 7, 2023
@Dartoxian Dartoxian removed this pull request from the merge queue due to a manual request Dec 7, 2023
@Dartoxian
Merge branch 'main' into bgazzard/service-logs-full-download
6cdad9b
@Dartoxian
fix: emui small design tweaks based on team feedback (#1897)
a1c61d0 
## Description:
This PR includes a number of the easier emui tweaks from the december
burndown:
* Don't show copy button next to the package source

![image](https://github.com/kurtosis-tech/kurtosis/assets/4419574/9b598336-b4f4-4793-96c5-5a1b99a3ba48)
* Make the delete button have a hover

![image](https://github.com/kurtosis-tech/kurtosis/assets/4419574/8f391477-c07f-4271-a9b9-cec848cfbde3)
* ellipsis long enclave names on the enclaves list

![image](https://github.com/kurtosis-tech/kurtosis/assets/4419574/2429b5de-63e8-492a-84fc-e67c9da7072e)
* Don't include entrypoint and returns on the catalog package page
* Dynamic package card layout

![image](https://github.com/kurtosis-tech/kurtosis/assets/4419574/e3f902fc-7d03-4032-bc24-83517f8f8cf2)
* support navigating logs with enter and shift+enter when searching
* fix an issue with log search that was causing excessive renders, which
I think was causing the `ok.` bug mentioned on notion.

## Is this change user facing?
YES

## References (if applicable):
- December burndown notion
@Dartoxian
Build
ce09c55
@Dartoxian Dartoxian enabled auto-merge December 7, 2023 10:21
@Dartoxian Dartoxian added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit b91333f Dec 7, 2023
33 checks passed
@Dartoxian Dartoxian deleted the bgazzard/service-logs-full-download branch December 7, 2023 21:30
@kurtosisbot kurtosisbot mentioned this pull request Dec 7, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2023
@kurtosisbot
chore(main): release 0.85.43 (#1913)
4065511 
🤖 I have created a release *beep* *boop*
---


##
[0.85.43](0.85.42...0.85.43)
(2023-12-11)


### Features

* Add new ports view to the EM UI
([#1919](#1919))
([027d74b](027d74b))
* add REST API bindings for TS and Golang
([#1907](#1907))
([97b9b80](97b9b80))
* add support for public ports
([#1905](#1905))
([97a3d95](97a3d95))
* enable building images in docker [image building pt. 1]
([#1911](#1911))
([c153873](c153873))
* Reverse proxy lifecycle management and connectivity on Docker
([#1906](#1906))
([69c5b27](69c5b27))
* service logs full download
([#1895](#1895))
([b91333f](b91333f))
* Unified REST API
([c3911f6](c3911f6))


### Bug Fixes

* add installation description for oapi-codegen
([#1917](#1917))
([8f2427b](8f2427b))
* Fix doc checker CI
([#1912](#1912))
([cc2696d](cc2696d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
h4ck3rk3y added a commit that referenced this pull request Dec 12, 2023
@h4ck3rk3y
Revert "feat: service logs full download (#1895)"
4072d42 
This reverts commit b91333f.
@kurtosisbot kurtosisbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adschwartz adschwartz adschwartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dartoxian @adschwartz