-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker compose integration [pt. 1] #2001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostbean
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments but looks good
core/server/api_container/server/docker_compose_transpiler/docker_compose_transpiler.go
Outdated
Show resolved
Hide resolved
core/server/api_container/server/docker_compose_transpiler/docker_compose_transpiler.go
Outdated
Show resolved
Hide resolved
core/server/api_container/server/docker_compose_transpiler/docker_compose_transpiler.go
Show resolved
Hide resolved
core/server/api_container/server/docker_compose_transpiler/docker_compose_transpiler.go
Show resolved
Hide resolved
tedim52
force-pushed
the
tedi/compose-transpiler
branch
from
January 4, 2024 15:11
c1d0c19
to
5078c51
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.85.56](0.85.55...0.85.56) (2024-01-05) ### Features * docker compose integration [pt. 1] ([#2001](#2001)) ([385833d](385833d)) ### Bug Fixes * in api/golang go.mod use a fixed version of the new utils sub package ([#2022](#2022)) ([05099e5](05099e5)) * Make the reverse proxy connect and disconnect to and from the enclave network idempotent ([#2004](#2004)) ([3cc68eb](3cc68eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
## Description: This feature allows users to run basic docker compose's with Kurtosis. Now, directories containing a `kurtosis.yml` OR a `docker-compose.yaml` are treated as starlark packages. If a compose package is detected, `APIC` converts the compose to Starlark, and executes the Starlark within enclaves. eg. `kurtosis run .` `kurtosis run github.com/awesome-compose/django` ## Is this change user facing? YES ## References: Part 1 (Docker Compose Transpiler) #2001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is the pt. 1 of enabling the use case:
This PR contains only the logic for transpiling docker compose into starlark. The next PR will integrate it with APIC.
Is this change user facing?
NO (next one will be).