-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker Implementation #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up bind volume for game-folder in order to update it upon pr's to repository. Remove necessity for external volume. Remove copy ocmmands from Dockerfile.
@kus I've now refactored this PR a bit. It is now working without issues. Feel free to merge/give feedback if something should be changed. |
Tested on Docker for Mac, and its working very well :) |
Thanks for the effort put into this @DanielDKnudsen |
Still doesnt work for me... checkout, .env properties, docker build, docker compose up and after the game DL this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature #59 and Addresses Discussion #25.
As for the issues with Docker discussed in #11, I have personally not had any issues when using a volume mounted to the container as well as running it in linux using WSL2.
This should feature should also make the setup of GCP instance, Linux and Windows a lot simpler - if they have Docker installed.