Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Script Issues #70

Closed
wants to merge 17 commits into from
Closed

Fix Windows Script Issues #70

wants to merge 17 commits into from

Conversation

IritaSee
Copy link
Contributor

In this PR, I wanted to add a little fix in 'Windows run-able' script generated by initialize_windows.sh by adding some extra cd .. in the second line of each script that needs to be outside of /scripts folder.

@IritaSee IritaSee added the bug Something isn't working label Jan 13, 2022
@IritaSee IritaSee requested a review from mattigrthr January 13, 2022 14:08
@IritaSee IritaSee self-assigned this Jan 13, 2022
@IritaSee IritaSee linked an issue Jan 13, 2022 that may be closed by this pull request
Running demo on Windows #62
Closed
mattigrthr
mattigrthr requested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@mattigrthr mattigrthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run_cli.sh also needs to have an additional change of directory to activate the venv correctly.

kuwala/scripts/initialize_windows.sh Outdated Show resolved Hide resolved
@IritaSee IritaSee requested a review from mattigrthr January 14, 2022 02:31
@IritaSee IritaSee marked this pull request as draft January 15, 2022 02:49
@IritaSee IritaSee marked this pull request as ready for review January 15, 2022 02:49
@IritaSee
Copy link
Contributor Author

IritaSee commented Jan 15, 2022 •
edited
Loading

As the result of my discussion with @mattigrthr here, we decided to use new approach to the problem by companying shell script entirely with Python script, so those who cannot run a shell script, can use the python script as an alternative.

@IritaSee
Copy link
Contributor Author

Branch conflicts with #71 resolved

mattigrthr
mattigrthr requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@mattigrthr mattigrthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to keep things more concise.

kuwala/README.md Outdated Show resolved Hide resolved
kuwala/README.md Outdated Show resolved Hide resolved
kuwala/README.md Outdated Show resolved Hide resolved
kuwala/README.md Outdated Show resolved Hide resolved
kuwala/README.md Outdated Show resolved Hide resolved
kuwala/scripts/shell/build_jupyter_notebook.sh Outdated Show resolved Hide resolved
kuwala/scripts/shell/create_zip_archive.sh Outdated Show resolved Hide resolved
kuwala/scripts/shell/initialize_git_submodules.sh Outdated Show resolved Hide resolved
kuwala/scripts/shell/run_cli.sh Outdated Show resolved Hide resolved
kuwala/scripts/shell/run_jupyter_notebook.sh Outdated Show resolved Hide resolved
@IritaSee IritaSee mentioned this pull request Feb 11, 2022
Closed
@mattigrthr
Copy link
Contributor

Closing this PR as we replaced the setup scripts with pre-built Docker images and improved documentation for the local Python setup of the CLI (including Windows).

The Dockerization of the CLI that would simplify the setup further is in a separate issue #101.

@mattigrthr mattigrthr closed this Mar 1, 2022
@mattigrthr mattigrthr deleted the fixes/windows_installation_issue_#62 branch March 1, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattigrthr mattigrthr mattigrthr requested changes

Assignees

@IritaSee IritaSee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running demo on Windows
2 participants
@IritaSee @mattigrthr