Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] 0.3.1 base branch #2961

Closed
wants to merge 1 commit into from
Closed

Conversation

mewim
Copy link
Member

@mewim mewim commented Feb 27, 2024

Reverts #2952

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.52%. Comparing base (d661d99) to head (cb02fe9).
Report is 3 commits behind head on master.

❗ Current head cb02fe9 differs from pull request most recent head 15bc801. Consider uploading reports for the commit 15bc801 to get more accurate results

Files Patch % Lines
src/include/storage/index/hash_index_builder.h 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
- Coverage   93.52%   93.52%   -0.01%     
==========================================
  Files        1117     1117              
  Lines       42925    42919       -6     
==========================================
- Hits        40147    40140       -7     
- Misses       2778     2779       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim marked this pull request as ready for review February 28, 2024 04:18
@mewim mewim force-pushed the revert-2952-hash-fix branch from cb02fe9 to 061bc82 Compare February 28, 2024 04:19
@mewim mewim force-pushed the revert-2952-hash-fix branch from 061bc82 to 15bc801 Compare February 28, 2024 04:56
@mewim mewim closed this Feb 28, 2024
@mewim mewim deleted the revert-2952-hash-fix branch February 28, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant