Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocols): add logging socket closing #2564

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

inkedsquid
Copy link
Contributor

@inkedsquid inkedsquid commented Nov 26, 2024

What does this PR do ?

This PR improve logging when client sockets are closed because a big payload was received.

How should this be manually tested?

  • Step 1 : Send a payload bigger than the limit via the SDK
  • Step 2 : Check the logs from Kuzzle

@rolljee rolljee changed the base branch from master to 2-dev December 2, 2024 10:33
Copy link

sonarqubecloud bot commented Dec 2, 2024

@inkedsquid inkedsquid marked this pull request as ready for review December 3, 2024 09:11
@inkedsquid inkedsquid self-assigned this Dec 3, 2024
@rolljee rolljee merged commit 3d6c8b2 into 2-dev Dec 19, 2024
55 checks passed
@rolljee rolljee deleted the feat/KZLPRD-616-socket-payload-closing-logging branch December 19, 2024 07:53
@kuzzle
Copy link
Contributor

kuzzle commented Dec 19, 2024

🎉 This PR is included in version 2.35.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuzzle
Copy link
Contributor

kuzzle commented Dec 19, 2024

🎉 This PR is included in version 2.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuzzle kuzzle added the released This issue/pull request has been released. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:enhancements released on @beta released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants