Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wayland window associations #2621

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ReillyBrogan
Copy link
Contributor

@ReillyBrogan ReillyBrogan commented Mar 20, 2024

Wayland uses the appId/desktopFileName window property to associate windows to the desktop launcher. 6dc728d renamed the .desktop launcher from kvirc.desktop to net.kvirc.KVIrc${CMAKE_KVIRC_VERSION_MAJOR}.desktop, however the desktopFileName window property was still being set to kvirc causing Wayland compositors to not correctly associate windows if they were behaving in a FreeDesktop specification compliant way (note that GNOME is not FreeDesktop-compliant here as they also use the StartupWMClass property from the .desktop to match with .desktop launchers as well as the filename).

On KDE Plasma 5 and 6 this would manifest in the following ways:

  • The generic Wayland icon would be shown in the top left of all kvirc windows, and underneath the window when using the overview effect.
  • If a user pinned the kvirc desktop file to the task manager and clicked it the created windows would not be correctly associated with the existing pinned desktop launcher and they would see duplicate icons in the task manager, one of which would be the pinned kvirc launcher and the other would be the kvirc windows.

This fixes all of those cases.

@ctrlaltca ctrlaltca merged commit 8c8adf2 into kvirc:master Mar 21, 2024
4 checks passed
@ctrlaltca
Copy link
Contributor

Thank you for the PR and the nice explanation of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants