Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wayland uses the
appId/desktopFileName
window property to associate windows to the desktop launcher. 6dc728d renamed the.desktop
launcher fromkvirc.desktop
tonet.kvirc.KVIrc${CMAKE_KVIRC_VERSION_MAJOR}.desktop
, however thedesktopFileName
window property was still being set tokvirc
causing Wayland compositors to not correctly associate windows if they were behaving in a FreeDesktop specification compliant way (note that GNOME is not FreeDesktop-compliant here as they also use theStartupWMClass
property from the.desktop
to match with.desktop
launchers as well as the filename).On KDE Plasma 5 and 6 this would manifest in the following ways:
This fixes all of those cases.