Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Added Mex for SimpleFlow #227

Open
wants to merge 1 commit into
base: v2.4
Choose a base branch
from
Open

Added Mex for SimpleFlow #227

wants to merge 1 commit into from

Conversation

12dmodel
Copy link

@12dmodel 12dmodel commented Feb 1, 2016

Added mex for simple flow algorithm. I was able to compile and run on ubuntu, with result attached:

screenshot - 02012016 - 02 57 11 pm

@amroamroamro
Copy link
Collaborator

I just want to point out that the function is already exposed in the master branch: https://github.com/kyamagu/mexopencv/blob/master/opencv_contrib/src/+cv/calcOpticalFlowSF.cpp (as well as the M-docs and unit test).

It should be easy to backport it to the v2.4 branch with minor changes; I believe it was under the "video" module in 2.x before getting moved to "optflow" contrib module in 3.x.

@kyamagu
Copy link
Owner

kyamagu commented Feb 2, 2016

@12dmodel Thanks for your PR. As @amroamroamro points out, there is already the same function in the master branch (for OpenCV 3.x). Can you compare them and check if you are able to backport so that we do not have two versions of the same function across branches?

@12dmodel
Copy link
Author

12dmodel commented Feb 2, 2016

Will do

On Monday, February 1, 2016, Kota Yamaguchi [email protected]
wrote:

@12dmodel https://github.com/12dmodel Thanks for your PR. As
@amroamroamro https://github.com/amroamroamro points out, there is
already the same function in the master branch (for OpenCV 3.x). Can you
compare them and check if you are able to backport so that we do not have
two versions of the same function across branches?


Reply to this email directly or view it on GitHub
#227 (comment).

@amroamroamro
Copy link
Collaborator

@kyamagu
about the failing CI checks:

  • in Travis, you could go to the settings page, and set the option "Build only if .travis.yml is present" to ON. That way a build wont be triggered on branches without the .travis.yml file (like v2.4 and so on).
  • similarly for AppVeyor, there's a checkbox titled "Skip branches without appveyor.yml" in the settings page

Changing these options in the web UI is the only way to skip building the other branches without having to create a dummy yml file in every branch.

@kyamagu
Copy link
Owner

kyamagu commented Feb 2, 2016

@amroamroamro Right, just updated the settings

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants