Skip to content

Commit

Permalink
Merge branch 'hotfix/bug_fix'
Browse files Browse the repository at this point in the history
  • Loading branch information
whomwah committed Jan 24, 2014
2 parents 1288d20 + 8731f72 commit 05818c2
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Motion::Project::App.setup do |app|

app.sparkle do
release :base_url, 'https://raw.github.com/kyan/kyan_bar/master'
release :version, '1.2.1'
release :version, '1.2.2'

# Optional settings
release :feed_filename, 'releases.xml'
Expand Down
10 changes: 7 additions & 3 deletions app/_views/vote_metrics_view.rb
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def draw_vote_txt
end

def draw_uvotes
if rating.positive_ratings.empty?
if blank?(rating.positive_ratings)
''.attrd
else
"▲".attrd({
Expand All @@ -92,7 +92,7 @@ def draw_uvotes
end

def draw_dvotes
if rating.negative_ratings.empty?
if blank?(rating.negative_ratings)
''.attrd
else
"▼".attrd({
Expand All @@ -115,6 +115,10 @@ def no_vote_txt

def no_votes?
return true if rating.nil?
rating.positive_ratings.empty? && rating.negative_ratings.empty?
blank?(rating.positive_ratings) && blank?(rating.negative_ratings)
end

def blank?(str)
str.respond_to?(:empty?) ? str.empty? : !str
end
end
4 changes: 2 additions & 2 deletions release_notes.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
KyanBar - version 1.2.1
KyanBar - version 1.2.2
-----------------------

Updates:

* Bug Fix
* Bug Fix for vote bug
11 changes: 5 additions & 6 deletions releases.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,23 @@
en
</language>
<pubDate>
Fri, 24 Jan 2014 09:44:31 +0000
Fri, 24 Jan 2014 13:23:30 +0000
</pubDate>
<atom:link href='https://raw.github.com/kyan/kyan_bar/master/releases.xml' rel='self' type='application/rss+xml'/>
<item>
<title>
KyanBar 1.2.1
KyanBar 1.2.2
</title>
<pubDate>
Fri, 24 Jan 2014 09:44:31 +0000
Fri, 24 Jan 2014 13:23:30 +0000
</pubDate>
<guid isPermaLink='false'>
KyanBar-1.2.1
KyanBar-1.2.2
</guid>
<sparkle:releaseNotesLink>
https://raw.github.com/kyan/kyan_bar/master/release_notes.html
</sparkle:releaseNotesLink>
<enclosure url='https://github.com/kyan/kyan_bar/releases/download/1.2.1/KyanBar.zip' length='4027689' type='application/octet-stream' sparkle:version='1.2.1' sparkle:dsaSignature='MC0CFEpZkg38m79IS93o3nbgI3cGu9LFAhUAg4aeO9NmqGZyy7m5vTndC7AyG4Q='/>
<enclosure url='https://github.com/kyan/kyan_bar/releases/download/1.2.2/KyanBar.zip' length='4028395' type='application/octet-stream' sparkle:version='1.2.2' sparkle:dsaSignature='MCwCFBUO4hj19TmTyXrKAd4kCGTe1RmmAhRh7C6k7hANANYSn1wvA3C1wwbpow=='/>
</item>
</channel>
</rss>

0 comments on commit 05818c2

Please sign in to comment.