I18n support/IP verification #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options[:message]` would only be used here if `:verify_dns` option is a hash but does not contain a `:message` key.
* Pass symbol to `errors.add` method, to trigger translation lookup * Provide custom messages and default fallback via `:message` option * Test that translations are actually used as expected
Given a SaaS website which lets user setup their own CNAME to access some resource, we want to ensure that the DNS record is not only present but points to the correct domain. To do this, we can check that the domain resolves to the same IP as the target domain for the CNAME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two new features.
I'd be happy if you could review my changes. I can split it into two separate PRs. But since the commits build on one another, I wanted to get your feedback first.
Add support for localized error messages
errors.addmethod, to trigger translation lookup:messageoptionAdd a
:same_ip_asoption to:verify_dnsGiven a SaaS website which lets users setup their own CNAME to access
some resource, we want to ensure that the DNS record is not only
present but points to the correct domain. To do this, we can check
that the domain resolves to the same IP as the target domain for the
CNAME.